add internal/compress/lz4 test

[vankichi]

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

• Test
  • create test for internal/compress/lz4
  • add comment for each exportable var/function for internal/compress/lz4
• Refactor
  • change to use named return at CompressVector() because to get an error which will be cause at defer function.

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.14.4
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.12.0

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan (2 commits squashed)

     ✅ add internal/compress/lz4 test

     ✅ fix

✅ f... ... ✅ f...

Squashed 2 commits:

• ✅ fix

• ✅ fix

     Update internal/compress/lz4.go

     Update internal/compress/lz4.go

     ✅ add new test pattern with opts is not nil

     ✅ fix

     ✅ add test

Powered by Pull Assistant. Last update 4730e0a ... 20e8870. Read the comment docs.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master

[codecov]

Codecov Report

Merging #643 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
+ Coverage   14.96%   15.13%   +0.17%     
==========================================
  Files         411      411              
  Lines       21536    21537       +1     
==========================================
+ Hits         3222     3259      +37     
+ Misses      18053    18024      -29     
+ Partials      261      254       -7     

Impacted Files	Coverage Δ
internal/compress/lz4.go	100.00% <100.00%> (+63.63%)	⬆️
internal/worker/worker.go	83.63% <0.00%> (-0.91%)	⬇️
internal/worker/queue.go	98.55% <0.00%> (+2.89%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c589e7e...20e8870. Read the comment docs.

[vankichi]

/rebase
/format

[hlts2]

LGTM

[vdaas-ci]

[REBASE] Rebase triggered by vankichi for branch: test/internal/compress/lz4

[kevindiu]

LGTM

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

[vankichi]

/rebase
/format
/approve

[vdaas-ci]

[REBASE] Rebase triggered by vankichi for branch: test/internal/compress/lz4

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

[vdaas-ci]

[APPROVED] This PR is approved by vankichi.