-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add internal/compress/lz4 test #643
Conversation
Best reviewed: commit by commit
Optimal code review plan (2 commits squashed)
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
+ Coverage 14.96% 15.13% +0.17%
==========================================
Files 411 411
Lines 21536 21537 +1
==========================================
+ Hits 3222 3259 +37
+ Misses 18053 18024 -29
+ Partials 261 254 -7
Continue to review full report at Codecov.
|
/rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REBASE] Rebase triggered by vankichi for branch: test/internal/compress/lz4 |
Signed-off-by: vankichi <kyukawa315@gmail.com>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
a04c31c
to
20e8870
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
/rebase |
[REBASE] Rebase triggered by vankichi for branch: test/internal/compress/lz4 |
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
Signed-off-by: vankichi kyukawa315@gmail.com
Description:
internal/compress/lz4
internal/compress/lz4
CompressVector()
because to get anerror
which will be cause at defer function.Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: