Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal/net/http/client test #858

Merged
merged 9 commits into from
Dec 8, 2020
Merged

Conversation

kevindiu
Copy link
Contributor

Description:

This PR implements http client test.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@kevindiu kevindiu requested a review from hlts2 November 24, 2020 06:07
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

internal/test/comparator/standard.go Show resolved Hide resolved
internal/test/comparator/standard.go Show resolved Hide resolved
internal/test/comparator/standard.go Show resolved Hide resolved
internal/net/http/client/client_test.go Show resolved Hide resolved
internal/net/http/client/client_test.go Show resolved Hide resolved
internal/net/http/client/client.go Outdated Show resolved Hide resolved
internal/net/http/client/client_test.go Show resolved Hide resolved
internal/net/http/client/client_test.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #858 (c8d5509) into master (aa681cf) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
+ Coverage   18.50%   18.65%   +0.15%     
==========================================
  Files         421      422       +1     
  Lines       19518    19572      +54     
==========================================
+ Hits         3611     3651      +40     
- Misses      15699    15712      +13     
- Partials      208      209       +1     
Impacted Files Coverage Δ
internal/net/http/client/client.go 89.47% <ø> (+89.47%) ⬆️
internal/net/http/json/json.go 48.75% <0.00%> (-31.25%) ⬇️
internal/worker/worker.go 83.33% <0.00%> (-1.05%) ⬇️
internal/net/net.go 85.18% <0.00%> (ø)
internal/worker/queue.go 100.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa681cf...348cc02. Read the comment docs.

hlts2
hlts2 previously approved these changes Nov 25, 2020
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu requested a review from hlts2 December 1, 2020 02:17
hlts2
hlts2 previously approved these changes Dec 1, 2020
internal/net/http/client/client_test.go Outdated Show resolved Hide resolved
internal/net/http/client/client_test.go Outdated Show resolved Hide resolved
internal/net/http/client/client_test.go Outdated Show resolved Hide resolved
@kevindiu
Copy link
Contributor Author

kevindiu commented Dec 3, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 3, 2020

[REBASE] Rebase triggered by kevindiu for branch: test/internal/net-http-client

kevindiu and others added 2 commits December 3, 2020 01:34
@github-actions github-actions bot force-pushed the test/internal/net-http-client branch from ad6882f to 348cc02 Compare December 3, 2020 01:34
@kevindiu kevindiu requested a review from hlts2 December 3, 2020 01:34
@kevindiu
Copy link
Contributor Author

kevindiu commented Dec 7, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 7, 2020

[REBASE] Rebase triggered by kevindiu for branch: test/internal/net-http-client

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

vankichi commented Dec 7, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 7, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/net-http-client

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 7, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 638f8dc into master Dec 8, 2020
@vankichi vankichi deleted the test/internal/net-http-client branch December 8, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants