Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should GLCreateContext use a *Window receiver? #325

Closed
jackmott opened this issue Apr 5, 2018 · 1 comment
Closed

should GLCreateContext use a *Window receiver? #325

jackmott opened this issue Apr 5, 2018 · 1 comment
Labels
enhancement This issue asks for enhancement in a specific part

Comments

@jackmott
Copy link

jackmott commented Apr 5, 2018

I expected to be able to call window.GLCreateContext() as other functions follow that pattern, but currently it is sdl.GLCreateContext(window)

@malashin
Copy link
Collaborator

malashin commented Apr 5, 2018

Hi @jackmott

I've merged the following changes into the Master branch. Thank you for bringing this up.

  • GLCreateContext(), GLMakeCurrent(), GLGetDrawableSize(), GLSwapWindow() are now methods of Window
  • Renamed GLSwapWindow() to GLSwap()
func (window *Window) GLCreateContext() {}
func (window *Window) GLMakeCurrent(glcontext GLContext) {}
func (window *Window) GLGetDrawableSize() {}
func (window *Window) GLSwap() {}

@malashin malashin added the enhancement This issue asks for enhancement in a specific part label Apr 5, 2018
@malashin malashin closed this as completed Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue asks for enhancement in a specific part
Projects
None yet
Development

No branches or pull requests

2 participants