Cli bofang #68
Merged
Cli bofang #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edit categorization benchmark to support default measurements, and add some metadata
|
@undertherain I understand why you use "clean_dic" function. However, in order to make this function work, I have to change tests code for every benchmark. Do you think I should do the changes in this branch? or maybe you can accept this pull request first, then I will start a new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit categorization benchmark to support default measurements, and add some metadata
the cli can't pass unit test, due to a "clean_dic" function used in "vecto\benchmarks\visualize.py"
so I just commented this function