Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X made no changes event in timeline #1430

Open
Bubu opened this issue May 30, 2020 · 7 comments · Fixed by #1436
Open

X made no changes event in timeline #1430

Bubu opened this issue May 30, 2020 · 7 comments · Fixed by #1436

Comments

@Bubu
Copy link
Contributor

Bubu commented May 30, 2020

I sometimes see X made no changes in the timeline in riotX. Riot-desktop filters such empty state events, I guess these shouldn't be shown in the timeline except when "Show hidden events" is selected from developer settings.

This is the event in question.
image

@bmarty
Copy link
Member

bmarty commented May 31, 2020

Yes, I've noticed that too, and one question I have is: what the point of sending such (useless?) events?
@Half-Shot, do you have an idea?

@Half-Shot
Copy link
Member

The homeserver should be no-opping a join request here. The bridge will join all rooms on startup to ensure it's joined, but it shouldn't be sending fresh join events into the room as the homeserver should be aware that the user is already in the room. Feels like a Synapse bug.

@bmarty bmarty self-assigned this Jun 2, 2020
bmarty added a commit that referenced this issue Jun 3, 2020
…ange

Hide "X made no changes" event by default in timeline (#1430)
@Bubu
Copy link
Contributor Author

Bubu commented Jun 20, 2020

Those events are still shown in the message preview in the chat list. I guess this is probably already tracked in better message previews in general somewhere?

@bmarty
Copy link
Member

bmarty commented Jun 25, 2020

We will have to check again. I reopen the issue

@bmarty bmarty reopened this Jun 25, 2020
@starcraft66
Copy link

I see this happen regularly.

@HarHarLinks
Copy link
Contributor

Still seeing this today in v1.1.9

@piotrvidal
Copy link

I also see this issue happening regularly. Android version 12.

Screenshot_20230808-134437-528.png

@bmarty bmarty removed their assignment Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants