Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable free style cropping for camera and gallery images #8325

Merged
merged 1 commit into from May 5, 2023

Conversation

networkException
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other:

Content

This pull request enables the ability to crop images uploaded from the gallery or taken from within the app without a fixed aspect ratio. This allows users to be specific about the parts of an image they wish to send.

Motivation and context

A friend told me how she has to use another messaging application to crop images as her screenshot tool has no editing tools and Element doesn't allow her to be specific.

Resolves #2356, which shows popular demand for the feature.

Note that support for free style cropping was previously removed in 3ac2296.

Screenshots / GIFs

Before After
old new

Tests

  • In a room, click on the plus icon left to the text input
  • Either use the gallery icon and select and image or take a photo
  • Click on the editing pen in the top right corner
  • The "Crop" tab now allows the dimensions of the rectangle selection to be edited with handles

Tested devices

  • Physical
  • Emulator
  • OS version(s): 5.0, 12.0

Checklist

This feature was disabled in 3ac2296.

Resolves element-hq#2356

Signed-off-by: networkException <git@nwex.de>
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label May 5, 2023
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I do not really remember why usability has been declared "not easy". Let's merge the PR for the next release and see if we get complaints about it!

@bmarty bmarty merged commit b5f1ecf into element-hq:develop May 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow aspect ratio free cropping of uploaded images
2 participants