New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB are no longer supporting Draft.js; perhaps we should switch to Slate.js or similar #6477

Closed
ara4n opened this Issue Apr 9, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@ara4n
Copy link
Member

ara4n commented Apr 9, 2018

@lukebarnard1

This comment has been minimized.

Copy link
Contributor

lukebarnard1 commented Apr 10, 2018

Slate does look very nice. I don't think it supports Entities like draftjs does, but looking at it I think it'd be possible to write a plugin for those sorts of things (if someone hasn't already).

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 7, 2018

i think it effectively does support entities via plugins, which are trivial to write. I’ve made a stab at this in my spare time on matrix-org/matrix-react-sdk#1890. It so far going fairly well: first of all commenting out all the Draft stuff, getting it working again pre-RTE but with Slate, and then uncommenting the Draft stuff again as it’s ported to Slate. So far Slate feels way nicer to work with, and has already fixed various weird races when trying to type and paste into the editor where characters would appear out of order, which was driving me nuts.

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 7, 2018

fixes #4708 already for instance

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Jul 16, 2018

done.

@ara4n ara4n closed this Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment