+address review about being conditionnaly fallible or infallible

Signed-off-by: prognant <pierre.rognant@datadoghq.com>
vectordotdev · Jun 18, 2021 · 6840c7e · 6840c7e
1 parent 1b096b3
commit 6840c7e
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/lib/vrl/stdlib/src/encode_key_value.rs b/lib/vrl/stdlib/src/encode_key_value.rs
@@ -121,7 +121,10 @@ impl Expression for EncodeKeyValueFn {
     }
 
     fn type_def(&self, _state: &state::Compiler) -> TypeDef {
-        TypeDef::new().bytes().fallible()
+        match &self.fields {
+            None => TypeDef::new().bytes().infallible(),
+            Some(_) => TypeDef::new().bytes().fallible(),
+        }
     }
 }
 
@@ -237,7 +240,7 @@ mod tests {
                 }
             ],
             want: Ok("lvl=info"),
-            tdef: TypeDef::new().bytes().fallible(),
+            tdef: TypeDef::new().bytes().infallible(),
         }
 
         multiple_elements {
@@ -248,7 +251,7 @@ mod tests {
                 }
             ],
             want: Ok("log_id=12345 lvl=info"),
-            tdef: TypeDef::new().bytes().fallible(),
+            tdef: TypeDef::new().bytes().infallible(),
         }
 
         string_with_spaces {
@@ -258,7 +261,7 @@ mod tests {
                     "msg" => "This is a log message"
                 }],
             want: Ok(r#"lvl=info msg="This is a log message""#),
-            tdef: TypeDef::new().bytes().fallible(),
+            tdef: TypeDef::new().bytes().infallible(),
         }
 
         string_with_characters_to_escape {
@@ -270,7 +273,7 @@ mod tests {
                     "space key" => "foo"
                 }],
             want: Ok(r#"another_field="some\\nfield\\and things" lvl=info msg="payload: {\"code\": 200}\\n" "space key"=foo"#),
-            tdef: TypeDef::new().bytes().fallible(),
+            tdef: TypeDef::new().bytes().infallible(),
         }
 
         nested_fields {
@@ -292,7 +295,7 @@ mod tests {
                     "event" => "log"
                 }],
                 want: Ok("agent.id=1234 agent.name=vector event=log log.file.path=encode_key_value.rs network.ip.0=127 network.ip.1=0 network.ip.2=0 network.ip.3=1 network.proto=tcp"),
-                tdef: TypeDef::new().bytes().fallible(),
+                tdef: TypeDef::new().bytes().infallible(),
         }
 
         fields_ordering {