+address reviews

Signed-off-by: prognant <pierre.rognant@datadoghq.com>
vectordotdev · Jun 22, 2021 · 8ccedb7 · 8ccedb7
1 parent 99c067d
commit 8ccedb7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/docs/reference/remap/functions/encode_logfmt.cue b/docs/reference/remap/functions/encode_logfmt.cue
@@ -5,11 +5,7 @@ remap: functions: encode_logfmt: {
 	description: #"""
 		Encodes the `value` to [logfmt](\#(urls.logfmt)).
 		"""#
-	notices: [
-		"""
-			
-			""",
-	]
+	notices:     functions.encode_key_value.notices
 
 	arguments: [
 		{

diff --git a/lib/vrl/stdlib/src/encode_key_value.rs b/lib/vrl/stdlib/src/encode_key_value.rs
@@ -121,10 +121,9 @@ impl Expression for EncodeKeyValueFn {
     }
 
     fn type_def(&self, _state: &state::Compiler) -> TypeDef {
-        match &self.fields {
-            None => TypeDef::new().bytes().infallible(),
-            Some(_) => TypeDef::new().bytes().fallible(),
-        }
+        TypeDef::new()
+            .bytes()
+            .with_fallibility(self.fields.is_some())
     }
 }