Skip to content

Commit

Permalink
fix(install.sh): Correctly shift all parsed arguments (#17684)
Browse files Browse the repository at this point in the history
<!--
**Your PR title must conform to the conventional commit spec!**

  <type>(<scope>)!: <description>

  * `type` = chore, enhancement, feat, fix, docs
  * `!` = OPTIONAL: signals a breaking change
* `scope` = Optional when `type` is "chore" or "docs", available scopes
https://github.com/vectordotdev/vector/blob/master/.github/semantic.yml#L20
  * `description` = short description of the change

Examples:

  * enhancement(file source): Add `sort` option to sort discovered files
  * feat(new source): Initial `statsd` source
  * fix(file source): Fix a bug discovering new files
  * chore(external docs): Clarify `batch_size` option
-->

Closes #17681 

Without `shift`ing the other possible input arguments, the `--prefix`
argument will set the `prefix` incorrectly. When using [the official
Docker
example](https://vector.dev/docs/setup/installation/#installation-script),
arguments of `-y --prefix` will result in the following error:

```
mkdir: unrecognized option '--prefix'
```

...as `"$2"` is `--prefix`, because `-y` was never `shift`ed out.

Adding a `shift` to the other arguments correctly removes them from the
argument list when parsed.
  • Loading branch information
andygeorge committed Jun 13, 2023
1 parent 19c4d4f commit f883575
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions distribution/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,11 @@ main() {
;;
--no-modify-path)
modify_path=no
shift
;;
-y)
prompt=no
shift
;;
*)
;;
Expand Down

0 comments on commit f883575

Please sign in to comment.