Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New azure_blob_storage sink #2402

Closed
perfectayush opened this issue Apr 22, 2020 · 6 comments
Closed

New azure_blob_storage sink #2402

perfectayush opened this issue Apr 22, 2020 · 6 comments
Labels
domain: logs Anything related to Vector's log events domain: sinks Anything related to the Vector's sinks have: should We should have this feature, but is not required. It is medium priority. provider: azure Anything `azure` service provider related type: feature A value-adding code addition that introduce new functionality.

Comments

@perfectayush
Copy link
Contributor

Vector already supports AWS S3 and Google cloud storage as sinks. Are there any plans to support azure blob storage?

Although I have limited experience in rust, I am willing to contribute for this one.

@binarylogic binarylogic added domain: sinks Anything related to the Vector's sinks type: new feature labels Apr 22, 2020
@binarylogic
Copy link
Contributor

Thanks @perfectayush, yes, we definitely want to support it given that Azure is popular. It's just been a matter of priority. We'd love for you to contribute, and the aws_s3 and gcp_cloud_storage sinks should provide good examples. I will warn you, these sinks are a little more complicated due to the fact that they can partition data across dynamic keys/paths. For example, the key_prefix option in the aws_s3 sink allows for templated values. We're happy to help. The best way to do that would be to open a draft pull request and we can comment on there.

@binarylogic binarylogic added the have: should We should have this feature, but is not required. It is medium priority. label Apr 22, 2020
@binarylogic binarylogic changed the title Support for Azure blob storage sink New azure_blob_storage sink Apr 22, 2020
@binarylogic binarylogic added the provider: azure Anything `azure` service provider related label Apr 23, 2020
@binarylogic binarylogic added type: feature A value-adding code addition that introduce new functionality. and removed type: new feature labels Jun 16, 2020
@binarylogic binarylogic added the domain: logs Anything related to Vector's log events label Aug 7, 2020
@elsesiy
Copy link

elsesiy commented Mar 23, 2021

We'd love to use vector but the lack of azure storage support is hard sell today. @perfectayush have you done any work on this? I'm happy to take a stab at it or co-author, let me know. Thanks!

@ArtemTrofimushkin
Copy link
Contributor

@perfectayush
Here is a draft version for AzureBlobSink, that I tried to implement.
Please, leave some comments about this

#6861

@perfectayush
Copy link
Contributor Author

Hi @ArtemTrofimushkin , @elsesiy I had taken a jab at it but couldn't move past due to inexperience in Rust and other work priorities. At that time, we decided to go ahead with azure file storage instead due to time constraints.

Also, I am not working on Azure Services anymore, so can't test this. I will give it a look, but core vector team is better suited to review it.

@ArtemTrofimushkin
Copy link
Contributor

@perfectayush Thanks for help!
Hi @binarylogic, can you take a look and give some comments about implementation, please?

#6861

@jszwedko
Copy link
Member

jszwedko commented Jul 6, 2021

Closed by #6861

@jszwedko jszwedko closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: logs Anything related to Vector's log events domain: sinks Anything related to the Vector's sinks have: should We should have this feature, but is not required. It is medium priority. provider: azure Anything `azure` service provider related type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

5 participants