-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: azure_blob sink #6861
enhancement: azure_blob sink #6861
Conversation
Thanks for contributing this @ArtemTrofimushkin ! We can review whenever it is ready. Let us know if you have any questions in the meanwhile. |
Hi, @jszwedko!
I also mentioned authors of the library about this behavior. What can I do with these tests? Should I leave them, disable them, document this behavior, or completely remove them? |
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
…hout compression Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
…rmatting Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Thanks, @jszwedko! |
…efault value for blob_prefix Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
b5f5955
to
eea8a28
Compare
@jszwedko I've pushed changes for documentation. Can you review it, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @ArtemTrofimushkin ! I left a few last comments, but this looks good to me. Thanks for adding the docs!
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
@jszwedko The corresponding changes pushed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for this contribution @ArtemTrofimushkin !
Head branch was pushed to by a user without write access
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
0298dfc
to
4e56d10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @ArtemTrofimushkin !
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Head branch was pushed to by a user without write access
dcfcf62
to
f2ea1d9
Compare
@jszwedko Thanks! |
@jszwedko Is anything else required? |
Yeah, that's weird, I'm not sure why the status didn't update here. I'll merge manually. Thanks again for this contribution @ArtemTrofimushkin ! |
Thanks for help! |
enhancement(azure_blob_sink): Draft implementation for azure_blob sink