Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New nginx_metrics source #3091

Closed
otisg opened this issue Jul 17, 2020 · 5 comments · Fixed by #5209
Closed

New nginx_metrics source #3091

otisg opened this issue Jul 17, 2020 · 5 comments · Fixed by #5209
Assignees
@fanatid
Labels
domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events domain: sources Anything related to the Vector's sources have: should We should have this feature, but is not required. It is medium priority. type: feature A value-adding code addition that introduce new functionality.
Milestone
2020-11-23: Pseud...

Comments

@otisg
Copy link

otisg commented Jul 17, 2020

For collecting Nginx (Plus) metrics.
@binarylogic binarylogic added event type: metric have: should We should have this feature, but is not required. It is medium priority. type: feature A value-adding code addition that introduce new functionality. labels Jul 17, 2020
@binarylogic binarylogic added domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events domain: sources Anything related to the Vector's sources and removed event type: metric labels Aug 6, 2020
@jszwedko jszwedko mentioned this issue Aug 28, 2020
Merged
@binarylogic binarylogic changed the title Add Nginx metrics source New nginx_metrics source Aug 30, 2020
@binarylogic binarylogic mentioned this issue Aug 30, 2020
Closed
@jamtur01 jamtur01 removed this from the 2020.08.17 - On The Road Again milestone Sep 8, 2020
@jszwedko jszwedko modified the milestone: 2020-09-14 - The Grid Sep 11, 2020
@otisg
Copy link
Author

otisg commented Sep 17, 2020

Since the RFC for this seems to be done, do you have a rough ETA for this? No pressure, just trying to plan around this. Thanks.

@binarylogic binarylogic added this to the 2020-09-28 - Derezzed milestone Sep 17, 2020
@binarylogic
Copy link
Contributor

@otisg it'll be in the next sprint, which starts on 9/28.

@jamtur01 jamtur01 removed this from the 2020-09-28 - Derezzed milestone Oct 14, 2020
@otisg
Copy link
Author

otisg commented Oct 21, 2020

@otisg it'll be in the next sprint, which starts on 9/28.

Looks like it was removed from there. @binarylogic do you know if you might have it in by the end of November?

@jamtur01
Copy link
Contributor

I think it'll be in before the end of November - we're parsing out some questions about code re-use but that aside we're moving ahead.

@binarylogic
Copy link
Contributor

The apache_metrics source laid the groundwork and set precedence, so I don't see any reason we wouldn't have it out by then.

@jamtur01 jamtur01 added this to the 2020-11-09: Augur of Dunlain milestone Nov 12, 2020
@fanatid fanatid mentioned this issue Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fanatid fanatid

Labels
domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events domain: sources Anything related to the Vector's sources have: should We should have this feature, but is not required. It is medium priority. type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Milestone
2020-11-23: Pseudo-chitin armor
Development

Successfully merging a pull request may close this issue.

feat(new source): Initial nginx_metrics source implementation vectordotdev/vector
5 participants
@jamtur01 @jszwedko @otisg @binarylogic @fanatid