Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable or reimplement API tests #6984

Open
jszwedko opened this issue Apr 2, 2021 · 1 comment
Open

Re-enable or reimplement API tests #6984

jszwedko opened this issue Apr 2, 2021 · 1 comment
Labels
domain: api Anything related to Vector's GraphQL API domain: tests Anything related to Vector's internal tests type: task Generic non-code related tasks

Comments

@jszwedko
Copy link
Member

jszwedko commented Apr 2, 2021 •
edited

As part of #5872 (673e30a) we commented out the API tests due to issues with them sometimes hanging. We should fix these or determine another way to gain confidence in the API code.

@pablosichert started looking in #6926
@jszwedko jszwedko added the type: task Generic non-code related tasks label Apr 2, 2021
@binarylogic binarylogic added domain: api Anything related to Vector's GraphQL API domain: tests Anything related to Vector's internal tests labels Apr 2, 2021
@pablosichert
Copy link
Contributor

For reference: in c201b8b I removed the reliance on rusty_fork and made sure the global state is cleanup up properly. This required several forks on upstream crates.

rust-lang/log#450 (comment) has a discussion about how we could do assertions against the logger without exposing an unsafe API to unset the logger.

@leebenson leebenson mentioned this issue Apr 20, 2021
Merged
@leebenson leebenson mentioned this issue Sep 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: api Anything related to Vector's GraphQL API domain: tests Anything related to Vector's internal tests type: task Generic non-code related tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jszwedko @leebenson @binarylogic @pablosichert