Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove events_in_total and events_out_total from the GraphQL API #9314

Closed
leebenson opened this issue Sep 23, 2021 · 0 comments · Fixed by #17516
Closed

Remove events_in_total and events_out_total from the GraphQL API #9314

leebenson opened this issue Sep 23, 2021 · 0 comments · Fixed by #17516
Labels
domain: api Anything related to Vector's GraphQL API type: tech debt A code change that does not add user value.

Comments

@leebenson
Copy link
Member

leebenson commented Sep 23, 2021 •
edited

The metrics events_in_total and events_out_total are now considered deprecated per the component spec; #9300 and #9313 add their successors to the API and have marked the above as deprecated in GraphQL schema.

They should be removed entirely in a future release.
@leebenson leebenson added type: enhancement A value-adding code change that enhances its existing functionality. domain: api Anything related to Vector's GraphQL API labels Sep 23, 2021
@leebenson leebenson self-assigned this Sep 23, 2021
@jszwedko jszwedko added type: tech debt A code change that does not add user value. and removed type: enhancement A value-adding code change that enhances its existing functionality. labels Sep 23, 2021
@jszwedko jszwedko changed the title Deprecate events_in_total and events_out_total in the GraphQL API Remove events_in_total and events_out_total from the GraphQL API Sep 23, 2021
@tobz tobz mentioned this issue May 26, 2023
Merged
@tobz tobz closed this as completed in 98c54ad May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: api Anything related to Vector's GraphQL API type: tech debt A code change that does not add user value.
Projects
None yet
Milestone
No milestone
2 participants
@jszwedko @leebenson