Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The aws_s3 sink is logging connection_closed_before_message_completed errors #9671

Open
2 tasks
binarylogic opened this issue Oct 18, 2021 · 1 comment · Fixed by #9703
Open
2 tasks

The aws_s3 sink is logging connection_closed_before_message_completed errors #9671

binarylogic opened this issue Oct 18, 2021 · 1 comment · Fixed by #9703
Labels
domain: networking Anything related to Vector's networking sink: aws_s3 Anything `aws_s3` sink related type: bug A code related bug.

Comments

@binarylogic
Copy link
Contributor

We're seeing reports from users that the aws_s3 sink is routinely logging connection_closed_before_message_completed errors, but the events_discarded_total metric is 0. They are also reporting that the large majority of events are being successfully written. We should look into this and...

  • Ensure we are handling this error properly. If so, we should lower the log to trace level.
  • Ensure data is not being dropped. If it is, discuss how this can be prevented and/or increment the events_discarded_total metric.
@binarylogic binarylogic added type: bug A code related bug. sink: aws_s3 Anything `aws_s3` sink related domain: networking Anything related to Vector's networking labels Oct 18, 2021
@jszwedko jszwedko assigned vladimir-dd and unassigned tobz Oct 19, 2021
vladimir-dd added a commit that referenced this issue Oct 19, 2021
@vladimir-dd
fix(s3 sink): close idle connections for aws s3 sinks
f38cdb9 
Fixes #9671
Signed-off-by: Vladimir Zhuk <vladimir.zhuk@datadoghq.com>
@vladimir-dd vladimir-dd mentioned this issue Oct 19, 2021
Merged
@yalinglee yalinglee mentioned this issue Apr 29, 2022
Open
@mhaggerty042 mhaggerty042 mentioned this issue May 24, 2022
Closed
@fuchsnj
Copy link
Member

fuchsnj commented Sep 13, 2022

There are several users reporting that this message is still being logged on 0.24.0 and 0.23.3

@fuchsnj fuchsnj reopened this Sep 13, 2022
@jszwedko jszwedko mentioned this issue Nov 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: networking Anything related to Vector's networking sink: aws_s3 Anything `aws_s3` sink related type: bug A code related bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aws_s3 sink): close idle connections for aws s3 sinks vectordotdev/vector
4 participants
@tobz @binarylogic @fuchsnj @vladimir-dd