fix(journald source): Cursor/checkpoint fixes #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkpoint value we store for journald sources is the cursor for the most recently output record. This means, when we seek back to it, the next record to be sourced will be duplicated from the previous run. Instead, we either need to advance to the next record immediately after restoring the cursor or before saving the cursor. The former is less complex to implement. Signed-off-by: Bruce Guenter <bruce@untroubled.org>
Previously, the journald source would not write out a checkpoint until there were no new records left in the journal. In the event of an interruptin during a long stretch of new records, this could cause duplicated records. This adds a batch limit to the reader so the checkpoint is updated at least once per batch. Signed-off-by: Bruce Guenter <bruce@untroubled.org>
LucioFranco
approved these changes
Oct 29, 2019
This was referenced Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues with the journald source checkpoint handling discovered while dealing with #1097 / #1105.