-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(new transform): Initial aws_ec2_metadata
transform imple…
#1325
Conversation
aws_ec2_metadat
transformaws_ec2_metadata
transform implementation
Update on this: I am not going to block this PR on this issue #1338 but it will mean that we will ship this initially without proper correlation logging. I don't think this will be a big deal since it should be quite obvious where the logs are coming from but this would be a good enhancment. |
This PR should be ready for review, I plan on adding docs tomorrow morning. @binarylogic just FYI this does not add iam role name as I couldn't find a way to fetch that, the api you provided expects the user to pass the role-name and the |
That's ok. Thanks for letting me know. |
You can curl
|
@jszwedko ah good point, the docs are not very clear about it being a directory listing but instead suggests that you need to have the name prior to invoking that request. https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instancedata-data-categories.html I will add this now then. Looks like a decent alternative. |
39c7aad
to
f8ad5c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice! I was going to say we should chat before bringing in the new futures stuff, but I definitely do not want to review the version of this that doesn't use async/await 😄
@@ -45,6 +45,7 @@ tracing-limit = { path = "lib/tracing-limit" } | |||
|
|||
# Tokio / Futures | |||
futures = "0.1.25" | |||
futures03 = { package = "futures", version = "0.3", default-features = false, features = ["compat"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: binarylogic <bjohnson@binarylogic.com>
d4b11a5
to
9bd10f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the output fields to the docs. Everything else is good.
aws_ec2_metadata
transform implementationaws_ec2_metadata
transform imple…
Opening this for initial feedback, most of the internals are complete, what is left is to build out the integration tests and figure out how we want to handle the
subnet_id
andvpc_id
since those require us to supply amac
address of the network interface we want to get the id's from.As for internal implementation, we are using an
evmap
that allows us to fill a map and then switch the pointers which should mean we don't have to acquire a lock for each event. This should perform just about the same as a regular transform. I think this method improves upon the previous design I came up with while being simpler in the critical path.This PR also introduces ways we can start to use
async/await
without our codebase.Closes #736
Ref fluent/fluent-bit#1780
Signed-off-by: Lucio Franco luciofranco14@gmail.com