-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vrl): add encode_gzip and decode_gzip functions #16039
feat(vrl): add encode_gzip and decode_gzip functions #16039
Conversation
- add decode_gzip function - add corresponding unit-tests - add documentation Tested: - Local unit-tests run - Local run with VRL
- add encode_gzip function - add tests - add documentation Tested: - Unit-tests - Local run with VRL
- fix tests - fix an example
✅ Deploy Preview for vrl-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vector-project canceled.
|
- fix example values and VRL compilation errors
Regression Test Results
Run ID: 53003071-47f8-4cb7-a90a-eaae0c1ce710 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Regression Test Results
Run ID: 88cf4aa7-5913-4cd6-9c5a-8fbf8909d524 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Regression Test Results
Run ID: 9b27cdb3-2ab5-412a-acf6-805878572474 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
I think would be a good decision to implement |
I'd probably lean towards keeping the PRs limited to just the related pairs. |
No problems :) |
Just as a note, we're short staffed on the engineers that would normally handle the VRL issues/PRs so there might be more of a delay - but hoping to have this reviewed early next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward to me - one requested change on the cue so it renders correctly as fallible
in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good enough to me. I second @spencergilbert's comment about the docs and I have a question about test data.
- change function to infallible - update unit-tests
3b9efa1
to
f706872
Compare
Regression Test Results
Run ID: 79f2ec70-700c-443e-8490-a1aa67ff0008 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Regression Test Results
Run ID: 059bb566-b687-4983-bcea-28b0c76b8f7e Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their Changes in
Fine details of change detection per experiment.
|
keyword: "compression_level", | ||
kind: kind::INTEGER, | ||
required: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd definitely add complexity but I wonder if we'd want to allow best
and fast
here as well - probably worth waiting until it's requested before adding, just came to mind.
I also realized I think these didn't get added to the playground - however, I'm not exactly sure what's needed to do that. I've asked internally, but with most of the VRL folks out I may need to do some digging on what's needed there. |
Hah, I might be just as simple as adding the new functions here - I can try that later today, unless you want to try and work through it yourself. |
- add encode_gzip and decode_gzip to VRL playground
Nice! Success @zamazan4ik - playground |
I will update the PRs with other encode/decode functions soon according to the changes from this PR and then will ping you their. Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment, otherwise looks good. Thanks for this!
Head branch was pushed to by a user without write access
@jszwedko Could you please enable auto-merge again?) |
Regression Test Results
Run ID: a5240009-6f23-495c-b92c-eec9722b9c08 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Co-authored-by: Jesse Szwedko <jesse@szwedko.me>
26e7e85
to
8048c25
Compare
Regression Test Results
Run ID: 12f51b71-366f-4a23-9a6b-f7fc68207e86 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Marked for merge, thanks again for this contribution @zamazan4ik ! |
Regression Test Results
Run ID: c0d172a0-e2dd-4896-868c-975c5282e2a5 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
* feat(vrl): add decode_gzip function - add decode_gzip function - add corresponding unit-tests - add documentation Tested: - Local unit-tests run - Local run with VRL * feat(vrl): add encode_gzip function - add encode_gzip function - add tests - add documentation Tested: - Unit-tests - Local run with VRL * fix: fix decode_gzip - fix tests - fix an example * docs: add missing param to encode_gzip docs * fix: fix tests - fix example values and VRL compilation errors * fix: code review - change function to infallible - update unit-tests * fix: add missing functions to VRL-playground - add encode_gzip and decode_gzip to VRL playground * Update lib/vrl/stdlib/src/encode_gzip.rs Co-authored-by: Jesse Szwedko <jesse@szwedko.me> Co-authored-by: Jesse Szwedko <jesse@szwedko.me>
Resolves #15978