Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(kubernetes_logs source): add more configuration info #16254

Merged
merged 4 commits into from
Feb 7, 2023

Conversation

davidhuie-dd
Copy link
Contributor

@davidhuie-dd davidhuie-dd commented Feb 2, 2023

Both a user in Discord and I made wrong assumptions about the k8s source because we didn't see a note about the origin of the logs (the host). This makes a note that users should configure a hostPath volume to share the logs dir if they use this source from within k8s.

Screenshot 2023-02-02 at 11 12 25 AM

@davidhuie-dd davidhuie-dd requested a review from a team February 2, 2023 19:16
@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit fdec91e
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/63e1a04c4abc640009e6288b

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit fdec91e
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63e1a04bdb25210008f2f256
😎 Deploy Preview https://deploy-preview-16254--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Feb 2, 2023
@neuronull
Copy link
Contributor

Looks fine to me but will await Spencer's approval

@davidhuie-dd davidhuie-dd enabled auto-merge (squash) February 7, 2023 00:54
@spencergilbert spencergilbert merged commit 2bfd639 into vectordotdev:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants