-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(kubernetes_logs source): add more configuration info #16254
Merged
spencergilbert
merged 4 commits into
vectordotdev:master
from
davidhuie-dd:dh/k8s-logs-update
Feb 7, 2023
Merged
docs(kubernetes_logs source): add more configuration info #16254
spencergilbert
merged 4 commits into
vectordotdev:master
from
davidhuie-dd:dh/k8s-logs-update
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vrl-playground canceled.
|
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
domain: external docs
Anything related to Vector's external, public documentation
label
Feb 2, 2023
Looks fine to me but will await Spencer's approval |
spencergilbert
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both a user in Discord and I made wrong assumptions about the k8s source because we didn't see a note about the origin of the logs (the host). This makes a note that users should configure a
hostPath
volume to share the logs dir if they use this source from within k8s.