Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(prometheus_scrape source): run requests in parallel with timeouts #18021

Merged
merged 16 commits into from
Jul 24, 2023
Merged

enhancement(prometheus_scrape source): run requests in parallel with timeouts #18021

merged 16 commits into from
Jul 24, 2023

Commits on Jul 19, 2023

  1. wrap the send in a tokio timeout with a 5s timeout

    @nullren
    nullren committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    25c982d View commit details
    Browse the repository at this point in the history

  2. make target timeout configurable

    @nullren
    nullren committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    4a74b30 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. creating http clients is actually pretty slow, but cloning it is fast

    @nullren
    nullren committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    3889e75 View commit details
    Browse the repository at this point in the history

  2. Update src/sources/http_client/client.rs 

    Co-authored-by: Doug Smith <dsmith3197@users.noreply.github.com>
    @nullren @dsmith3197
    nullren and dsmith3197 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    3b06af5 View commit details
    Browse the repository at this point in the history

  3. Update src/sources/prometheus/scrape.rs 

    Co-authored-by: Doug Smith <dsmith3197@users.noreply.github.com>
    @nullren @dsmith3197
    nullren and dsmith3197 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    d753d5f View commit details
    Browse the repository at this point in the history

  4. update config names and interval behavior

    @nullren
    nullren committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    996bca7 View commit details
    Browse the repository at this point in the history

  5. let user specify timeout directly, no extra logic

    @nullren
    nullren committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    bf8b3dd View commit details
    Browse the repository at this point in the history

  6. warn if timeout is larger than scrape interval

    @nullren
    nullren committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    55d8da1 View commit details
    Browse the repository at this point in the history

  7. updated docs

    @nullren
    nullren committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    1e38e01 View commit details
    Browse the repository at this point in the history

  8. rename to have _secs suffix for consistency with interval

    @nullren
    nullren committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    71fb84a View commit details
    Browse the repository at this point in the history

  9. DRY up interval warning

    @nullren
    nullren committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ca322e7 View commit details
    Browse the repository at this point in the history

  10. rename target_timeout to timeout

    @nullren
    nullren committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    3a110ee View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Update src/sources/prometheus/scrape.rs 

    Co-authored-by: Stephen Wakely <stephen@lisp.space>
    @nullren @StephenWakely
    nullren and StephenWakely committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    2955e58 View commit details
    Browse the repository at this point in the history

  2. similar comment in http_client

    @nullren
    nullren committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    ca0869e View commit details
    Browse the repository at this point in the history

  3. regenerate docs

    @nullren
    nullren committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    57fd7f2 View commit details
    Browse the repository at this point in the history

  4. make make check-clippy happy

    @nullren
    nullren committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    bb01ed0 View commit details
    Browse the repository at this point in the history