Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): fix issues when using container tools and cargo is not installed locally #18112

Merged
merged 4 commits into from
Aug 1, 2023

Commits on Jul 29, 2023

  1. fix(dev): fix error in make when cargo is not installed

    Fixes the following error when using `make environment`:
    
        make: cargo: No such file or directory
    
    Signed-off-by: Hugo Hromic <hhromic@gmail.com>
    hhromic committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    f27dd9c View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. fix(dev): fix build make target when cargo is not installed

    Fixes the following error when using `make build ENVIRONMENT=true`:
    
        Makefile:212: *** "Please install Rust: https://www.rust-lang.org/tools/install".  Stop.
    
    Also switch to using `command` (POSIX compatible) instead of `which` for detecting `cargo`.
    Details in <https://mywiki.wooledge.org/BashFAQ/081>.
    
    Signed-off-by: Hugo Hromic <hhromic@gmail.com>
    hhromic committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    7efb9d2 View commit details
    Browse the repository at this point in the history
  2. fix(dev): fix detection of container tool in make

    Fixes the following error when `ENVIRONMENT=true` and neither Docker or Podman are available:
    
        make: podman: No such file or directory
        make: *** [Makefile:174: build] Error 127
    
    Podman was being used as fallback even if also not available.
    A descriptive error is now reported instead in this situation.
    
    Signed-off-by: Hugo Hromic <hhromic@gmail.com>
    hhromic committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    508aeb9 View commit details
    Browse the repository at this point in the history
  3. chore: add ifneq Makefile keyword to spell checker allow-list

    Signed-off-by: Hugo Hromic <hhromic@gmail.com>
    hhromic committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    1a64561 View commit details
    Browse the repository at this point in the history