Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(adaptive_concurrency): support configuring the initial ARC limit #18175
feat(adaptive_concurrency): support configuring the initial ARC limit #18175
Changes from 1 commit
b439ba7
f0f1d62
5f20cda
4978ce9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After taking another look, there are some small changes we'll want to make to improve the documentation and introduce safe-guards for the user.
Option<usize>
tousize
with a default value of 1. This way the default value of 1 will automatically be included in the documentation, rather than having to specify it in the doc comment, which may go out of sync.#[configurable(validation(range(min = 1, max = MAX_CONCURRENCY)))]
) to the value to ensure that the user does not set it aboveMAX_CONCURRENCY
.Farther down the file, you'll want to add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unable to pass
MAX_CONCURRENCY
(or"MAX_CONCURRENCY"
) to the validation range, so I instead passed200
directly and added a comment to theMAX_CONCURRENCY
constant that any change to the constant should also be made to this range.