Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only export RemoteWriteConfig for remote-write feature #19569

Merged
merged 1 commit into from Jan 9, 2024

Conversation

StephenWakely
Copy link
Contributor

@StephenWakely StephenWakely commented Jan 9, 2024

A recent PR #10304 caused an error in the features CI check. This fixes that error.

Note the features job still fails due to errors that are fixed in #19567.

Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
@StephenWakely StephenWakely requested a review from a team January 9, 2024 17:42
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Jan 9, 2024
@StephenWakely
Copy link
Contributor Author

/ci-run-component-features

@StephenWakely StephenWakely added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 9, 2024
@StephenWakely StephenWakely added this pull request to the merge queue Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

Regression Detector Results

Run ID: 1a4b6e00-df5b-4be7-9931-9f0d1ba6e78a
Baseline: 2b25a99
Comparison: 05b07ab
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole egress throughput +3.00 [+0.51, +5.48]
otlp_http_to_blackhole ingress throughput +1.14 [+0.98, +1.30]
http_elasticsearch ingress throughput +1.13 [+1.06, +1.19]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.80 [+0.71, +0.89]
datadog_agent_remap_datadog_logs ingress throughput +0.57 [+0.46, +0.67]
http_text_to_http_json ingress throughput +0.50 [+0.36, +0.65]
http_to_http_noack ingress throughput +0.04 [-0.05, +0.14]
http_to_http_json ingress throughput +0.03 [-0.05, +0.10]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.15]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.16, +0.16]
syslog_loki ingress throughput -0.03 [-0.13, +0.06]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.04 [-0.15, +0.07]
enterprise_http_to_http ingress throughput -0.07 [-0.14, +0.01]
splunk_hec_route_s3 ingress throughput -0.09 [-0.58, +0.40]
http_to_s3 ingress throughput -0.15 [-0.42, +0.13]
datadog_agent_remap_blackhole ingress throughput -0.16 [-0.26, -0.06]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.29 [-0.41, -0.16]
otlp_grpc_to_blackhole ingress throughput -0.62 [-0.71, -0.53]
socket_to_socket_blackhole ingress throughput -0.83 [-0.93, -0.73]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.88 [-1.02, -0.74]
datadog_agent_remap_blackhole_acks ingress throughput -1.22 [-1.33, -1.11]
syslog_humio_logs ingress throughput -1.23 [-1.34, -1.12]
syslog_splunk_hec_logs ingress throughput -1.27 [-1.35, -1.20]
fluent_elasticsearch ingress throughput -1.52 [-1.99, -1.04]
syslog_log2metric_humio_metrics ingress throughput -1.98 [-2.13, -1.84]
http_to_http_acks ingress throughput -2.26 [-3.56, -0.96]
syslog_regex_logs2metric_ddmetrics ingress throughput -2.31 [-2.42, -2.20]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 05b07ab Jan 9, 2024
44 of 46 checks passed
@StephenWakely StephenWakely deleted the stephen/prometheus_feature branch January 9, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants