Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(journald source): Fix handling of message array data #2053

Merged
merged 2 commits into from
Mar 17, 2020
Merged

fix(journald source): Fix handling of message array data #2053

merged 2 commits into from
Mar 17, 2020

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Mar 12, 2020

Closes #1714

Bruce Guenter added 2 commits March 12, 2020 16:28
Simplify journal tests a little
b5ea690 
Signed-off-by: Bruce Guenter <bruce@timber.io>
Re-parse non-ASCII messages output by journalctl
f86bba0 
When a non-ASCII message is stored in the journald log, journalctl will
output it as an array of bytes. When we encounter such arrays, translate
them into UTF-8 lossily.

Signed-off-by: Bruce Guenter <bruce@timber.io>
@bruceg bruceg added type: bug A code related bug. source: journald Anything `journald` source related labels Mar 12, 2020
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**:

  • For each failure path, is there sufficient context logged for users to investigate the issue?
  • Do the tests ensure that behavior is sane for inputs that don't meet normal assumptions (e.g. missing field, non-string, etc)?
  • Did you add adequate documentation?

This is an automatically generated QA checklist based on modified files

binarylogic
binarylogic approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@binarylogic binarylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look great!

@bruceg bruceg merged commit 07c42a1 into master Mar 17, 2020
@bruceg bruceg deleted the journald-parse-array branch March 17, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoverbear Hoverbear Hoverbear approved these changes

@binarylogic binarylogic binarylogic approved these changes

Assignees

@Hoverbear Hoverbear

Labels
source: journald Anything `journald` source related type: bug A code related bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON Parse Errors in journald source JSON
3 participants
@bruceg @Hoverbear @binarylogic