-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move third-party proto files into their own module #20556
Conversation
To avoid cyclical dependencies between lib/vector-core/proto and proto/ Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Note that the |
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.44s Total Time |
Regression Detector ResultsRun ID: 9a1cb517-e019-4fbe-8b9f-53c9e7166da1 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | syslog_log2metric_humio_metrics | ingress throughput | +2.84 | [+2.70, +2.97] |
➖ | syslog_humio_logs | ingress throughput | +2.38 | [+2.24, +2.51] |
➖ | fluent_elasticsearch | ingress throughput | +0.81 | [+0.33, +1.29] |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | +0.53 | [+0.45, +0.61] |
➖ | http_to_http_acks | ingress throughput | +0.29 | [-1.06, +1.65] |
➖ | syslog_loki | ingress throughput | +0.26 | [+0.22, +0.29] |
➖ | http_to_http_noack | ingress throughput | +0.07 | [-0.03, +0.17] |
➖ | socket_to_socket_blackhole | ingress throughput | +0.06 | [-0.02, +0.15] |
➖ | http_to_s3 | ingress throughput | +0.06 | [-0.22, +0.33] |
➖ | http_elasticsearch | ingress throughput | +0.04 | [-0.03, +0.12] |
➖ | http_to_http_json | ingress throughput | +0.04 | [-0.03, +0.12] |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | -0.00 | [-0.15, +0.14] |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | -0.01 | [-0.15, +0.14] |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.01 | [-0.12, +0.11] |
➖ | syslog_splunk_hec_logs | ingress throughput | -0.04 | [-0.12, +0.04] |
➖ | enterprise_http_to_http | ingress throughput | -0.08 | [-0.13, -0.02] |
➖ | file_to_blackhole | egress throughput | -0.13 | [-2.67, +2.41] |
➖ | otlp_grpc_to_blackhole | ingress throughput | -0.18 | [-0.27, -0.09] |
➖ | datadog_agent_remap_blackhole | ingress throughput | -0.53 | [-0.62, -0.44] |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | -0.75 | [-0.86, -0.65] |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -1.10 | [-1.23, -0.97] |
➖ | http_text_to_http_json | ingress throughput | -1.29 | [-1.40, -1.17] |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -1.32 | [-1.43, -1.21] |
➖ | otlp_http_to_blackhole | ingress throughput | -1.34 | [-1.47, -1.22] |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -1.46 | [-1.56, -1.35] |
➖ | splunk_hec_route_s3 | ingress throughput | -1.51 | [-1.96, -1.06] |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | -1.84 | [-1.95, -1.72] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Regression Detector ResultsRun ID: b82104a4-7cc8-4bab-a507-6dce6419c822 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | +1.42 | [+1.29, +1.55] |
➖ | otlp_http_to_blackhole | ingress throughput | +1.12 | [+0.97, +1.27] |
➖ | syslog_humio_logs | ingress throughput | +0.98 | [+0.78, +1.18] |
➖ | http_text_to_http_json | ingress throughput | +0.21 | [+0.09, +0.34] |
➖ | http_to_http_noack | ingress throughput | +0.18 | [+0.08, +0.27] |
➖ | http_to_http_json | ingress throughput | +0.04 | [-0.04, +0.12] |
➖ | syslog_log2metric_humio_metrics | ingress throughput | +0.04 | [-0.07, +0.15] |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | +0.04 | [-0.07, +0.15] |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | +0.03 | [-0.05, +0.11] |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.00 | [-0.15, +0.15] |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | -0.00 | [-0.14, +0.13] |
➖ | enterprise_http_to_http | ingress throughput | -0.01 | [-0.08, +0.06] |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.04 | [-0.15, +0.08] |
➖ | http_to_s3 | ingress throughput | -0.06 | [-0.34, +0.21] |
➖ | datadog_agent_remap_blackhole | ingress throughput | -0.10 | [-0.19, -0.01] |
➖ | http_elasticsearch | ingress throughput | -0.25 | [-0.34, -0.17] |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -0.30 | [-0.38, -0.23] |
➖ | socket_to_socket_blackhole | ingress throughput | -0.31 | [-0.38, -0.23] |
➖ | fluent_elasticsearch | ingress throughput | -0.46 | [-0.94, +0.02] |
➖ | syslog_splunk_hec_logs | ingress throughput | -0.58 | [-0.63, -0.53] |
➖ | otlp_grpc_to_blackhole | ingress throughput | -0.60 | [-0.69, -0.51] |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -0.96 | [-1.08, -0.85] |
➖ | syslog_loki | ingress throughput | -1.32 | [-1.39, -1.26] |
➖ | splunk_hec_route_s3 | ingress throughput | -1.37 | [-1.82, -0.92] |
➖ | file_to_blackhole | egress throughput | -1.65 | [-4.17, +0.86] |
➖ | http_to_http_acks | ingress throughput | -1.72 | [-3.07, -0.38] |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | -1.79 | [-1.90, -1.68] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
…ev#20556) * chore: Move third-party proto files into their own module To avoid cyclical dependencies between lib/vector-core/proto and proto/ Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> * Fix vector-core build.rs Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> * Fix prometheus-parser build.rs too Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> * loki too Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> --------- Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
To avoid cyclical dependencies between lib/vector-core/proto and proto/