Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transforms): Fix array insertion in field path notation #2062

Merged
1 commit merged into from Mar 16, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 14, 2020

This PR fixes a bug in the new implementation of field path notation.

When value was inserted in the middle of an array, then instead of replacing the already present value with the same index, it shifted all values to the right. This was not consistent with what we had with in the previous flatten/unflatten implementation.

Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@github-actions
Copy link

github-actions bot commented Mar 14, 2020

Great PR! Please pay attention to the following items before merging:

Files matching src/**:

  • For each failure path, is there sufficient context logged for users to investigate the issue?
  • Do the tests ensure that behavior is sane for inputs that don't meet normal assumptions (e.g. missing field, non-string, etc)?
  • Did you add adequate documentation?

This is an automatically generated QA checklist based on modified files

@binarylogic binarylogic removed the request for review from Hoverbear March 16, 2020 16:24
@ghost ghost merged commit b237576 into master Mar 16, 2020
@ghost ghost deleted the field-path-notation-array-insert-fix branch March 25, 2020 17:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants