enhancement(ux)!: Use external tagging for metrics serialization #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
ghost
requested review from
Hoverbear
added
type: enhancement
lukesteensen
approved these changes
Apr 6, 2020
binarylogic
approved these changes
Apr 6, 2020
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
|
I've updated the Schema section in the metrics data model description, so now all kinds of metrics are documented as top-level fields. The fact that only one object of each kind can be present in a metric now mentioned in the beginning of the section. Not sure is it possible or necessary to separate "one of" fields ( |
I don't think so. Looks good to me. |
binarylogic
added
domain: data model
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change that closes #2021.
One reason to have it is that it would make metrics representation in
stdoutsink consistent with it in Lua transform. However, it might break compatibility for those who rely on this serialization.