fix(loki sink): Pass tls settings to healthcheck #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
lukesteensen
approved these changes
Apr 6, 2020
I am not totally sure, we probably have this issue in other sinks. I think the best option here is to use the type system to ensure the only way we can generate TlsSettings is from our config? I think that would be much better than writing a test for each sink. |
|
I mean the best way would be to stop creating http clients twice, but we still should be verifying things work properly no matter how we solve it. I'd go ahead and merge this if you don't have an idea for a quick fix. I'll add an issue to audit other sinks for this issue. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lucio Franco luciofranco14@gmail.com