-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(networking)!: Remove custom DNS resolution #2812
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
@Jeffail I'll remove you from review since your file is only slightly changed in tests. But you are welcome to review nevertheless. |
If we want to have it centrally configure - we definitely want it to be passed centrally. However, I'm not sure what our intent is. |
But it does require the runtime, that's why it must be called from inside of one. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Very excited to see this happen.
Even though we've dropped the state, I still think it's fine to keep resolver
on the context and access it that way. This means users of the API don't need to care how it's implemented and we can do things like thread an executor automatically.
Noting, do not merge this, we are getting |
The error started popping elsewhere too so it's not related to this PR. |
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
* Remove trust-dns Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Remove unecessary clone Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Further simplify Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Try with ipv4 Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Comment Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Use block_on in a test Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Closes #2635.
Open questions
dns
configurable and it's fine to not callspawn_blocking
through a runtime handle, then we can further remove passingResolver
through contexts and functions, and instead constructResolver
directly at call site. EDIT: We'll keep it as it is.cc. @lukesteensen