fix(reduce transform): improve array handling #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Hoverbear
reviewed
Jul 15, 2020
| @@ -77,12 +77,11 @@ impl ReduceState { | |||
| fn new(e: LogEvent, strategies: &IndexMap<String, MergeStrategy>) -> Self { | |||
| Self { | |||
| stale_since: Instant::now(), | |||
| // TODO: all_fields alternative that consumes | |||
Hoverbear
reviewed
Jul 15, 2020
| r#" | ||
| identifier_fields = [ "request_id" ] | ||
|
|
||
| merge_strategies.foo = "array" |
There was a problem hiding this comment.
How about one for concat?
Hoverbear
suggested changes
Jul 15, 2020
I actually started down this path and backed out because it seemed slightly out of scope. The main thing that stopped me was that the current |
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
|
Ok that's fine with me! |
Hoverbear
approved these changes
Jul 15, 2020
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
|
Just kidding, it wasn't that bad. Just pushed an implementation. |
Hoverbear
approved these changes
Jul 15, 2020
|
|
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
Signed-off-by: Luke Steensen <luke.steensen@gmail.com> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3074
Two bugs fixed here:
all_fieldsinstead ofinto_itergaves us paths instead of keys, so thing like arrays and objects would not get strategized correctly.ArrayMergermeant that the initial array would be flattened in the result but subsequent additions would not.