New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: Add events for starting, stopping, and reloading #3476
Conversation
Signed-off-by: ktf <krunotf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this again and taking @jamtur01's comment into account, I'm starting to think that it's worth differentiating between normal graceful shutdowns and the immediate forced shutdown. That would clear up the code path confusion and give us higher quality information about what's happening with the process.
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Going with the theme of past tense, the points of emissions have been moved to reflect this. Regarding the shutdown event, I've added a fix to the @lukesteensen this ties into immediate forced shutdown, it is highly unlikely that any event emitted on that path will be propagated further than There are also errors in main which we could turn into events. |
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
* Add process events Signed-off-by: ktf <krunotf@gmail.com> * Use past tense Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * One last metric capture Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * One more move Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Remove unused use Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
…dotdev#3476) * Add process events Signed-off-by: ktf <krunotf@gmail.com> * Use past tense Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * One last metric capture Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * One more move Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Remove unused use Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
…dotdev#3476) * Add process events Signed-off-by: ktf <krunotf@gmail.com> * Use past tense Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * One last metric capture Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * One more move Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Remove unused use Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Closes #3448.
Added events emit:
Vector is starting.
Vector is reloading.
Vector is stopping.
logs respectively. This differs from what it used to be, but it reflects the metrics and is more streamlined.
Open questions
logs are emitted under fixed
target = "vector"
to avoidvector::internal_events::process:
being logged as the call site. Haven't seen what's our stance on that. It should be possible to extendemit!
macro to set target as the actual emit site, or is this the intended behavior? (Edit: it should be fine to use target for now)Should we use lowercase
vector
? (Edit: useVector
for emphasis)