-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Rename host
options to endpoint
#3590
Conversation
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you have here is good, but just offering that another option for consolidating to just use endpoint
would be to use:
tcp://
for thedatadog
one; this may make it easier to allow use of their HTTPS endpoint latersyslog+tcp://
for thepapertrail
one; similarly we could allow use of their HTTPS endpoint later. Edit it looks like they also support udp as well as tcp without TLS too, though I'm not sure we do (https://help.papertrailapp.com/kb/configuration/encrypting-remote-syslog-with-tls-ssl/).
The downside is the schemes would be required even though only one is current supported; though I don't think this is different from the pulsar
sink and HTTP based sinks probably only really allow for https
for the cloud-based services.
I don't see why the datadog_logs and papertrail sinks are being moved away from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine except for the endpoint
=> address
question.
Now, that is current situation, but with future upgrades mentioned by @jszwedko it makes more sense to retain them as endpoints.
We can supply/assume a default scheme if none is specified. |
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, didn't get back to this as quickly as I'd like. This looks good to me. I like your idea of a "default scheme".
* Rename Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Update usages of renamed Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Revert endpoint Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Update tests Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Revert docs Signed-off-by: ktf <krunotf@gmail.com> * More test updates Signed-off-by: ktf <krunotf@gmail.com> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Ref. #1775
This PR address the core of the #1775 and renames
host
options toendpoint
where applicable. Old names are still usable, while the documentation is updated to useendpoint
.This also changes:
(Edit: reverted)datadog_logs
sinkendpoint
option intoaddress
since the option fits address definition and not endpoint.(Edit: reverted)papertrail
sinkendpoint
option intoaddress
for the same reason.pulsar
sinkaddress
option intoendpoint
since that option fits endpoint definition.