docs: Added MongoDB sink RFC #3681
Conversation
Signed-off-by: James Turnbull <james@lovedthanlost.net>
jamtur01
added
domain: metrics
|
Apologies for the delay in review! This one had fallen off my radar. |
Signed-off-by: James Turnbull <james@lovedthanlost.net>
Signed-off-by: James Turnbull <james@lovedthanlost.net>
binarylogic
modified the milestones:
2020-08-31 - Digitization Laser,
2020-09-14 - The Grid
Signed-off-by: James Turnbull <james@lovedthanlost.net>
| - `mongodb_extra_info_heap_usage_bytes` (gauge) | ||
| - `mongodb_extra_info_page_faults` (gauge) | ||
| - `mongodb_instance_local_time` (gauge) | ||
| - `mongodb_instance_uptime_estimate_seconds_total` (counter) |
There was a problem hiding this comment.
It's still not clear to me what the difference is between this one and mongodb_instance_uptime_seconds_total; even after looking at https://docs.mongodb.com/manual/reference/command/serverStatus/ . Are you aware? The number seems to be the same when I ran a local mongodb docker container.
There was a problem hiding this comment.
I actually can't work out the difference.
uptime
The number of seconds that the current MongoDB process has been active.
uptimeEstimate
The uptime in seconds as calculated from MongoDB’s internal course-grained time keeping system.
I guess someone might want both?
There was a problem hiding this comment.
It is definitely unclear to me 😄 but I'm fine with reporting both given that serverStatus does. Maybe they differ in certain circumstances.
Signed-off-by: James Turnbull <james@lovedthanlost.net>
|
Ping @JeanMertz @binarylogic I need two more approvals to merge this. Thanks! |
Signed-off-by: James Turnbull <james@lovedthanlost.net>
There was a problem hiding this comment.
Looks good, nice work. I have no idea what these metrics mean, but I'm happy to see they are consistent with the Prometheus metrics. I do wonder if the naming could be improved though. Prefixes like mongodb_mongod_metrics seem redundant, but I don't have enough MongoDB context to know for sure.
|
Something like |
|
Last call @JeanMertz :) Otherwise, I'm going to accept the two approvals here - if others have feedback feel free to reach out prior to implementation. |
* draft Signed-off-by: James Turnbull <james@lovedthanlost.net> * More edits Signed-off-by: James Turnbull <james@lovedthanlost.net> * Addressed feedback from Jesse Signed-off-by: James Turnbull <james@lovedthanlost.net> * Fixed checks Signed-off-by: James Turnbull <james@lovedthanlost.net> * Fixed two more metric names Signed-off-by: James Turnbull <james@lovedthanlost.net> * More edits from Jesse Signed-off-by: James Turnbull <james@lovedthanlost.net> * Added full metrics Signed-off-by: James Turnbull <james@lovedthanlost.net> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Closes #3641