chore(architecture): Remove resolver from context #4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Removing the Resolver made it superfluous Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
jszwedko
requested review from
bruceg,
StephenWakely,
JeanMertz and
MOZGIII
as code owners
lukesteensen
approved these changes
Oct 27, 2020
src/sinks/aws_cloudwatch_logs/mod.rs
Outdated
| @@ -187,7 +187,7 @@ impl SinkConfig for CloudwatchLogsSinkConfig { | |||
| let log_group = self.group_name.clone(); | |||
| let log_stream = self.stream_name.clone(); | |||
|
|
|||
| let client = self.create_client(cx.resolver())?; | |||
| let client = self.create_client(dns::Resolver)?; | |||
There was a problem hiding this comment.
It doesn't need to happen as part of this PR, but it'd be nice to keep pushing this down to the point where it's actually used and get rid of the readability overhead of the threading entirely.
To where it is used Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
|
@lukesteensen I pushed it all the way down in the last commit if you want to take a peek 👀 |
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
* Remove Resolver from SinkContext Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * Remove TransformContext Removing the Resolver made it superfluous Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * Push dns::Resolver further down the stack To where it is used Signed-off-by: Jesse Szwedko <jesse@szwedko.me> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4749
Conversation: #4685
This removes injection of the
Resolvertype viaTransformContextandSinkContext. As this was the only field forTransformContext, I dropped that type.