Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(logdna sink): Support template syntax in hostname and tags field #4884

Merged
merged 6 commits into from Nov 6, 2020
Merged

enhancement(logdna sink): Support template syntax in hostname and tags field #4884

merged 6 commits into from Nov 6, 2020

Conversation

juchiast
Copy link
Contributor

@juchiast juchiast commented Nov 5, 2020

close #3777

@juchiast
Template and partition
e7f18d9 
Signed-off-by: Duy Do <juchiast@gmail.com>
@juchiast
Merge branch 'master' into juchiast/logdna
937978f
@juchiast
testing
34212bf 
Signed-off-by: Duy Do <juchiast@gmail.com>
@juchiast
partition test
3a38276 
Signed-off-by: Duy Do <juchiast@gmail.com>
@juchiast juchiast added type: enhancement A value-adding code change that enhances its existing functionality. sink: logdna labels Nov 5, 2020
@juchiast juchiast self-assigned this Nov 5, 2020
@juchiast juchiast changed the title enhanchment(logdna sink): Support template syntax in hostname and tags field enhancement(logdna sink): Support template syntax in hostname and tags field Nov 5, 2020
fanatid
fanatid approved these changes Nov 5, 2020
View reviewed changes
src/sinks/logdna.rs Outdated Show resolved Hide resolved
@juchiast
with_capacity
2a7d193 
Signed-off-by: Duy Do <juchiast@gmail.com>
bruceg
bruceg approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@bruceg bruceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, just one question about a test.

src/sinks/logdna.rs Outdated Show resolved Hide resolved
@juchiast
remove clone
f3493ac 
Signed-off-by: Duy Do <juchiast@gmail.com>
@juchiast juchiast merged commit aade9e6 into master Nov 6, 2020
@juchiast juchiast deleted the juchiast/logdna branch November 6, 2020 02:50
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
@juchiast
enhancement(logdna sink): Support template syntax in hostname and tag…
f1f99bc 
…s field (vectordotdev#4884)

* Template and partition

Signed-off-by: Duy Do <juchiast@gmail.com>

* testing

Signed-off-by: Duy Do <juchiast@gmail.com>

* partition test

Signed-off-by: Duy Do <juchiast@gmail.com>

* with_capacity

Signed-off-by: Duy Do <juchiast@gmail.com>

* remove clone

Signed-off-by: Duy Do <juchiast@gmail.com>
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruceg bruceg bruceg approved these changes

@fanatid fanatid fanatid approved these changes

Assignees

@juchiast juchiast

Labels
type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support template syntax in hostname and tags field for LogDNA sink
3 participants
@juchiast @bruceg @fanatid