Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(journald source): handle incorrect int sequences as strings #5683

Merged
merged 1 commit into from Dec 23, 2020
Merged

fix(journald source): handle incorrect int sequences as strings #5683

merged 1 commit into from Dec 23, 2020

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Dec 22, 2020

Closes #5617

Now if an array is not a valid integer sequence (non-ASCII string) value will be serialized as a string,

@fanatid
fix(sources-journald): handle incorrect int sequences as strings
3fe0671 
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
@fanatid fanatid added the source: journald Anything `journald` source related label Dec 22, 2020
@fanatid fanatid added this to the 2020-12-21 Kryptek Yeti milestone Dec 22, 2020
@fanatid fanatid requested a review from bruceg December 22, 2020 16:58
@fanatid fanatid self-assigned this Dec 22, 2020
@fanatid fanatid changed the title fix(sources-journald): handle incorrect int sequences as strings fix(journald source): handle incorrect int sequences as strings Dec 22, 2020
@jamtur01 jamtur01 merged commit ee27b68 into master Dec 23, 2020
@jamtur01 jamtur01 deleted the journald-seq-as-str branch December 23, 2020 03:43
@jamtur01
Copy link
Contributor

jamtur01 commented Dec 23, 2020 •
edited

Looks like some test failures: https://github.com/timberio/vector/runs/1598524355?check_suite_focus=true

failures:
    sources::journald::tests::excludes_units
    sources::journald::tests::handles_checkpoint
    sources::journald::tests::reads_journal

@fanatid fanatid mentioned this pull request Dec 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruceg bruceg bruceg approved these changes

Assignees

@fanatid fanatid

Labels
source: journald Anything `journald` source related
Projects
None yet
Milestone
2020-12-21 Kryptek Yeti
Development

Successfully merging this pull request may close these issues.

Invalid record from journald errors on NetworkManager events
3 participants
@fanatid @jamtur01 @bruceg