Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(remap): Add base64 encoding and decoding functions #5768

Merged
merged 24 commits into from
Jan 11, 2021

Conversation

lucperkins
Copy link
Contributor

This PR adds VRL functions for encoding and decoding Base64 data. For encoding, there's a padding option provided that defaults to true, as called for in #5758. There are other options we could explore here but I think this is a useful first iteration.

Closes #5758

Luc Perkins added 3 commits December 30, 2020 21:54
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Luc Perkins added 5 commits December 30, 2020 23:04
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
@jamtur01 jamtur01 added the domain: vrl Anything related to the Vector Remap Language label Jan 1, 2021
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small comments.

lib/remap-functions/src/decode_base64.rs Outdated Show resolved Hide resolved
lib/remap-functions/src/encode_base64.rs Outdated Show resolved Hide resolved
lib/remap-functions/src/encode_base64.rs Outdated Show resolved Hide resolved
Luc Perkins added 2 commits January 4, 2021 09:15
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Copy link
Contributor

@JeanMertz JeanMertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Left a few more notes, but overall this looks good.

lib/remap-functions/src/encode_base64.rs Outdated Show resolved Hide resolved
lib/remap-functions/src/encode_base64.rs Outdated Show resolved Hide resolved
lib/remap-functions/src/decode_base64.rs Outdated Show resolved Hide resolved
lib/remap-functions/src/decode_base64.rs Outdated Show resolved Hide resolved
Luc Perkins and others added 5 commits January 5, 2021 10:35
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Luc Perkins added 6 commits January 8, 2021 15:07
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
@lucperkins lucperkins merged commit 1b9880c into master Jan 11, 2021
@lucperkins lucperkins deleted the remap-base64-funcs branch January 11, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: vrl Anything related to the Vector Remap Language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remap: add functions to encode / decode base64
5 participants