chore(observability): Bump to tui 14 #5975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebenson
added
the
domain: observability
jszwedko
approved these changes
Jan 11, 2021
src/top/dashboard.rs
Outdated
| @@ -121,6 +119,13 @@ impl<'a> Widgets<'a> { | |||
| /// Renders a components table, showing sources, transforms and sinks in tabular form, with | |||
| /// statistics pulled from `ComponentsState`, | |||
| fn components_table<B: Backend>(&self, f: &mut Frame<B>, state: &state::State, area: Rect) { | |||
| // Header columns | |||
| let header = ["Name", "Kind", "Type", "Events", "Bytes", "Errors"] | |||
There was a problem hiding this comment.
Not a big deal, but it seems like we could have left the constant and still did the mapping in here.
There was a problem hiding this comment.
Ah, that's a remnant from my experiments with pad, where column labels could occupy different widths depending on padding. This can indeed be static.
Signed-off-by: Lee Benson <lee@leebenson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
vector topto tui 14. Closes #5289.This wound up being smaller in scope than I would have liked. The highlight of tui 14 is the ability to control
Cell-level styling. We're using that to set the row header text to bold.I had anticipated right-aligning metrics columns, but layout's
Alignmentstruct appears specific to layouts and not text. I experimented with pad to prefix with spaces manually based on the largest column dimensions, but since we're using percentage widths to accommodate fluid terminal sizes, and text truncates below a certain size, there didn't appear to be a consistent way to anticipate exact column dimensions outside of tui's own layout rendering.There's an open issue on tui requesting this. I'll revisit if/when that feature is implemented. Not a huge deal either way. Just think it'll look nicer.