enhancement(remap): Add charset parameter to encode_base64 function #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 14, 2021 13:21
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
jszwedko
reviewed
Jan 15, 2021
Signed-off-by: Luc Perkins <luc@timber.io>
|
@jszwedko Ah yes, you're quite right about the fallibility of the charset. I've updated that. |
|
@jszwedko Though, quick nit slash FYI: it doesn't make the function always fallible. Rather, it makes the function fallible if |
Signed-off-by: Luc Perkins <luc@timber.io>
lucperkins
force-pushed
the
remap-base64-charsets
branch
from
95be921
to
03e8d93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
charsetparameter to theencode_base64function with two possible values:standardandurl_safe. It's fairly trivial to add others in the future.Closes #6011