fix(sample transform)!: Accept remap conditions #7864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for the `sample` transform were updated to use an example remap condition but the component itself only accepted `check_fields`-style conditions. This updates the component to allow either condition style (similar to the `filter` transform). I updated the tests to just use the new remap style rather than check both. I think it's fine to rely on the tests in `src/condition` to cover the differences between conditions. Fixes: #7863 Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
jszwedko
requested review from
spencergilbert,
a team and
StephenWakely
and removed request for
a team
spencergilbert
approved these changes
Jun 15, 2021
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
jszwedko
changed the title
|
I marked this as a breaking change given that it switches the condition default to the remap syntax. |
|
The test failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for the
sampletransform were updated to use an example remapcondition but the component itself only accepted
check_fields-styleconditions. This updates the component to allow either condition style
(similar to the
filtertransform).I updated the tests to just use the new remap style rather than check
both. I think it's fine to rely on the tests in
src/conditionto coverthe differences between conditions.
Fixes: #7863
Signed-off-by: Jesse Szwedko jesse@szwedko.me