enhancement(remap): Add assert_eq! function #7866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
spencergilbert
approved these changes
Jun 16, 2021
JeanMertz
approved these changes
Jun 16, 2021
lib/vrl/stdlib/benches/benches.rs
Outdated
| @@ -10,6 +10,7 @@ criterion_group!( | |||
| // https://github.com/timberio/vector/pull/6408 | |||
| config = Criterion::default().noise_threshold(0.05); | |||
| targets = assert, | |||
| assert_eq, | |||
There was a problem hiding this comment.
Suggested change
| assert_eq, | |
| assert_eq, |
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
|
Just a small note, we forgot to add docs here which is being covered in #8265 |
Doh, yep. Thanks @lucperkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
assert_eq!function with the goal of making writingunit tests easier.
The output may change with
#6261 to make it easier to see
the condition that failed.
Closes #7833
Signed-off-by: Jesse Szwedko jesse@szwedko.me