enhancement(config): Allow wildcards anywhere in identifiers #7873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#6170 had added support for wildcards in identifiers in vector configs, but only as the last character. This PR expands support to allow glob matching in the same way that `vector tap` does which allows for `*` to appear anywhere in the input name. Closes #6786 Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
jszwedko
requested review from
spencergilbert,
a team,
bruceg and
lukesteensen
and removed request for
a team
bruceg
reviewed
Jun 15, 2021
src/config/compiler.rs
Outdated
Comment on lines
117
to
120
| Err(error) => { | ||
| error!(message = "Invalid glob pattern for input.", component_name = name, %error); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Should this error, or just do an exact match?
There was a problem hiding this comment.
Hmm, that's true, maybe an exact match would be acceptable. Although the user may be confused if they were trying to use a pattern that ended up being invalid.
Maybe we could emit a warning and then do an exact match?
jszwedko
changed the title
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
bruceg
approved these changes
Jun 16, 2021
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6170 had added support for
wildcards in identifiers in vector configs, but only as the last
character. This PR expands support to allow glob matching in the same
way that
vector tapdoes which allows for*to appear anywhere inthe input name.
Closes #6786
Signed-off-by: Jesse Szwedko jesse@szwedko.me