enhancement(vrl): Add format_int and parse_int functions
#8078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For converting integers to/from strings. We currently have `to_int` which is equivalent to `parse_int(foo, 10)`, but the added `parse_int` is able to: * Parse in a specified base * Determine the base of the number by looking at its prefix (e.g. 0x -> 16) I added an analogous `format_int` for going the other way. Closes: #7228 Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
jszwedko
requested review from
a team,
pablosichert,
JeanMertz,
spencergilbert and
StephenWakely
and removed request for
a team and
pablosichert
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
spencergilbert
approved these changes
Jun 30, 2021
| ] | ||
| } | ||
|
|
||
| fn examples(&self) -> &'static [Example] { |
There was a problem hiding this comment.
Is it legally required to always use 42 for example numbers 😛
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
spencergilbert
approved these changes
Jun 30, 2021
001wwang
pushed a commit
to 001wwang/vector
that referenced
this pull request
Jul 7, 2021
…otdev#8078) * enhancement(vrl): Add `format_int` and `parse_int` functions For converting integers to/from strings. We currently have `to_int` which is equivalent to `parse_int(foo, 10)`, but the added `parse_int` is able to: * Parse in a specified base * Determine the base of the number by looking at its prefix (e.g. 0x -> 16) I added an analogous `format_int` for going the other way. Closes: vectordotdev#7228 Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For converting integers to/from strings.
We currently have
to_intwhich is equivalent toparse_int(foo, 10),but the added
parse_intis able to:16)
I added an analogous
format_intfor going the other way.Closes: #7228
Signed-off-by: Jesse Szwedko jesse@szwedko.me