enhancement(search website): Add page tags to search index #8261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucperkins
changed the title
|
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: f361610 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/60f73dee85d7390008bb9fb6 😎 Browse the preview: https://deploy-preview-8261--vector-project.netlify.app |
lucperkins
requested review from
a team and
JeanMertz
and removed request for
a team
lucperkins
force-pushed
the
search-index-page-tags
branch
from
cc38e2b
to
12de2ce
Compare
zsherman
reviewed
Jul 20, 2021
|
@zsherman That was a relic of us changing the branching scheme for the website. Fixed via rebase. |
lucperkins
force-pushed
the
search-index-page-tags
branch
from
8d9a442
to
906b3b4
Compare
added 9 commits
July 20, 2021 14:19
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins
force-pushed
the
search-index-page-tags
branch
from
906b3b4
to
f361610
Compare
zsherman
approved these changes
Jul 20, 2021
lucperkins
pushed a commit
that referenced
this pull request
Jul 21, 2021
* Add tags to indexing and trim titles Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Change meta element name to keywords Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Update JS search widget to use hierarchy instead of tags Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix Typescript type issue in indexing script Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Try different TS syntax for undefined Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix or error in script Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix more or/default issues Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Remove unused dependencies and variables and refactor section recursion Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Add .env file to gitignore Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> Co-authored-by: Luc Perkins <luc.perkins@datadoghq.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 21, 2021
* Add tags to indexing and trim titles Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Change meta element name to keywords Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Update JS search widget to use hierarchy instead of tags Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix Typescript type issue in indexing script Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Try different TS syntax for undefined Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix or error in script Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix more or/default issues Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Remove unused dependencies and variables and refactor section recursion Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Add .env file to gitignore Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> Co-authored-by: Luc Perkins <luc.perkins@datadoghq.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 21, 2021
* Add tags to indexing and trim titles Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Change meta element name to keywords Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Update JS search widget to use hierarchy instead of tags Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix Typescript type issue in indexing script Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Try different TS syntax for undefined Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix or error in script Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix more or/default issues Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Remove unused dependencies and variables and refactor section recursion Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Add .env file to gitignore Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> Co-authored-by: Luc Perkins <luc.perkins@datadoghq.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 22, 2021
* Add tags to indexing and trim titles Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Change meta element name to keywords Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Update JS search widget to use hierarchy instead of tags Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix Typescript type issue in indexing script Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Try different TS syntax for undefined Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix or error in script Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix more or/default issues Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Remove unused dependencies and variables and refactor section recursion Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Add .env file to gitignore Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> Co-authored-by: Luc Perkins <luc.perkins@datadoghq.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 28, 2021
* Add tags to indexing and trim titles Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Change meta element name to keywords Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Update JS search widget to use hierarchy instead of tags Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix Typescript type issue in indexing script Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Try different TS syntax for undefined Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix or error in script Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Fix more or/default issues Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Remove unused dependencies and variables and refactor section recursion Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> * Add .env file to gitignore Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com> Co-authored-by: Luc Perkins <luc.perkins@datadoghq.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the search indexing logic for the new vector.dev to include per-page tags. It also performs some basic input sanitation by ensuring that there's no extraneous whitespace in section titles. Including tags should improve the search sensitivity and give us more per-page levers that we can use to influence result sets.
Please note that this renames what was previously the
tagsfield tohierarchyto make room for what I feel is a more intuitively namedtagsfield.