Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css website): Fix overflow scroll behavior on component pages #8321

Merged
merged 2 commits into from Jul 15, 2021

Conversation

lucperkins
Copy link
Contributor

This PR addresses a scrolling that appears only on component pages (i.e. /docs/reference/configuration/{sources,transforms,sinks}/*).

Luc Perkins added 2 commits July 15, 2021 10:54
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
@netlify
Copy link

netlify bot commented Jul 15, 2021

✔️ Deploy Preview for vector-project ready!

🔨 Explore the source changes: 7b491c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/60f076cfcdd6b9000821e90c

😎 Browse the preview: https://deploy-preview-8321--vector-project.netlify.app

Copy link
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Booyah - looks perfect

@lucperkins lucperkins merged commit 60c743d into master Jul 15, 2021
@lucperkins lucperkins deleted the fix-component-page-scrolling-issue branch July 15, 2021 18:00
jszwedko pushed a commit that referenced this pull request Jul 15, 2021
)

* Add overflow-auto to component page sidebar

Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>

* Add overflow-auto to TOC div for component pages

Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>

Co-authored-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins pushed a commit that referenced this pull request Jul 19, 2021
)

* Add overflow-auto to component page sidebar

Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>

* Add overflow-auto to TOC div for component pages

Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>

Co-authored-by: Luc Perkins <luc.perkins@datadoghq.com>
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants