enhancement(dnstap source): Make sure ITs are independent of container #8347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endent of container Signed-off-by: Yunkun Zhu <yzhu@bluecatnetworks.com>
yunkunzhu
requested review from
a team and
JeanMertz
and removed request for
a team
|
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: 2720790 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/60f1c2741f348a00071b9029 😎 Browse the preview: https://deploy-preview-8347--vector-project.netlify.app |
|
Hi @jszwedko, this changeset is to make sure dnstap source ITs are not dependent on the container in regards to #8302 (comment). Thank you. |
jszwedko
approved these changes
Jul 16, 2021
|
I tested this out locally and it looks good. |
lucperkins
pushed a commit
that referenced
this pull request
Jul 19, 2021
…endent of container (#8347) Signed-off-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Co-authored-by: Yunkun Zhu <yzhu@bluecatnetworks.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 19, 2021
…endent of container (#8347) Signed-off-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Co-authored-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 20, 2021
…endent of container (#8347) Signed-off-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Co-authored-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 21, 2021
…endent of container (#8347) Signed-off-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Co-authored-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 21, 2021
…endent of container (#8347) Signed-off-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Co-authored-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 21, 2021
…endent of container (#8347) Signed-off-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Co-authored-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 22, 2021
…endent of container (#8347) Signed-off-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Co-authored-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 28, 2021
…endent of container (#8347) Signed-off-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Co-authored-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
jaysonsantos
pushed a commit
to jaysonsantos/vector
that referenced
this pull request
Aug 1, 2021
…endent of container (vectordotdev#8347) Signed-off-by: Yunkun Zhu <yzhu@bluecatnetworks.com> Co-authored-by: Yunkun Zhu <yzhu@bluecatnetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yunkun Zhu yzhu@bluecatnetworks.com
This enhancement is based on the comment #8302 (comment). It makes sure to do proper cleanup in the end of each IT test case and let IT test cases not dependent on the container.