enhancement(topology): Remove ComponentId.value
#8808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebenson
added
type: enhancement
|
✔️ Deploy Preview for vector-project canceled. 🔨 Explore the source changes: 1e8126b 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/61252116eaa68200080b0507 |
|
Although, I'm going to put it back right away 🤔 |
|
@jdrouet, if you have an imminent PR that reverts this, feel free to close. |
|
I'll have one today I think |
|
like this one #8810 |
Signed-off-by: Lee Benson <lee@leebenson.com>
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
|
I ended up updating this PR to also switch displaying the ids in logs to using I'll merge once CI passes to get it into the release. (apologies for any conflicts @jdrouet ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small adjustment per #8706 (comment) to remove the
ComponentId.valuefield.