feat(clickhouse sink): Add support for basic auth #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albert <63851587@qq.com>
binarylogic
changed the title
binarylogic
previously requested changes
Sep 26, 2019
There was a problem hiding this comment.
Thanks @amuluowin ! Regarding the docs, we need to add the options to .meta/sinks/clickhouse.toml and then run make generate to update the options in all places across the docs.
Let me know if you are having trouble and we can have someone here do it.
|
This is my first time using ruby, after |
LucioFranco
reviewed
Sep 30, 2019
|
Otherwise this LGTM besides the docs issue. |
LucioFranco
approved these changes
Oct 4, 2019
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the code and docs