Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file sink): Fix compilation of tests #9684

Merged
merged 1 commit into from Oct 19, 2021
Merged

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Oct 18, 2021

#9589 was not fully up to date with master and introduced a compilation error in the tests.

Signed-off-by: Bruce Guenter bruce.guenter@datadoghq.com

Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
@bruceg bruceg added type: bug A code related bug. sink: file Anything `file` sink related domain: unit tests Anything related to Vector's unit testing feature labels Oct 18, 2021
@bruceg bruceg requested a review from jszwedko October 18, 2021 23:29
@bruceg bruceg self-assigned this Oct 18, 2021
@netlify
Copy link

netlify bot commented Oct 18, 2021

✔️ Deploy Preview for vector-project ready!

🔨 Explore the source changes: 4f2fb73

🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/616e033d2e3ed200074a8e07

😎 Browse the preview: https://deploy-preview-9684--vector-project.netlify.app

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just noticed this too.

@bruceg bruceg enabled auto-merge (squash) October 18, 2021 23:55
@jszwedko jszwedko merged commit b100f78 into master Oct 19, 2021
@jszwedko jszwedko deleted the file-sink-component-fixes branch October 19, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: unit tests Anything related to Vector's unit testing feature sink: file Anything `file` sink related type: bug A code related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants